Implement roving tabindex on grouped blocks toolbars #23216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
requested review from
ajitbohra,
ellatrix,
nerrad,
ntwb,
talldan and
youknowriad
as code owners
diegohaz
added
[a11y] Keyboard & Focus
[Focus] Accessibility (a11y)
gziolo
reviewed
Jun 17, 2020
packages/e2e-tests/specs/editor/various/toolbar-roving-tabindex.test.js
Outdated
Show resolved
Hide resolved
|
Size Change: -1 B Total Size: 1.12 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Jun 17, 2020
packages/e2e-tests/specs/editor/various/toolbar-roving-tabindex.test.js
Outdated
Show resolved
Hide resolved
gziolo
reviewed
Jun 17, 2020
|
Updated the styles. After #23230 no change is needed here. Using |
gziolo
approved these changes
Jun 17, 2020
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #18619, whose main goal is to implement roving tabindex on the
@wordpress/components'Toolbarcomponent and use it on the header and block toolbars so they become a single tab stop as recommended by the WAI-ARIA Toolbar Pattern. Related issues are #15331 and #3383.This PR implements the roving tabindex method on grouped blocks toolbars. It stopped working after #21056, so I'm also including some end-to-end tests.