Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overriding popover content padding #23270

Merged
merged 1 commit into from
Jun 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
.block-editor-block-alignment-matrix-toolbar__popover {
.components-popover__content {
min-width: 0;
padding: $grid-unit;
width: auto;

> div {
padding: $grid-unit;
}
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

// Forcing some space above the list of options in
// the dropdown to visually balance them.
.block-editor-media-replace-flow__options .components-popover__content {
.block-editor-media-replace-flow__options .components-popover__content > div {
padding-top: $grid-unit-20;
}

Expand Down
5 changes: 4 additions & 1 deletion packages/block-library/src/heading/editor.scss
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
// Remove padding in heading level control popover since the toolbar buttons already have padding.
.block-library-heading-level-dropdown .components-popover__content {
padding: 0;
// TODO: Find a less hardcoded way of doing this. `max-content` works on
// Chromium, but it results in a scrollbar on Safari, and isn't supported
// at all in IE11.
min-width: 230px;

> div {
padding: 0;
}
}

// The dropdown already has a border, so we can remove the one on the heading
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/navigation-link/editor.scss
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
margin-left: -4px;
}

.wp-block-navigation-link__dropdown-content .components-popover__content {
.wp-block-navigation-link__dropdown-content .components-popover__content > div {
padding: $grid-unit-10 0;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/autocomplete/style.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.components-autocomplete__popover .components-popover__content {
.components-autocomplete__popover .components-popover__content > div {
padding: $grid-unit-20;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/dropdown/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
display: inline-block;
}

.components-dropdown__content .components-popover__content {
.components-dropdown__content .components-popover__content > div {
padding: $grid-unit-15;
}
5 changes: 4 additions & 1 deletion packages/components/src/tooltip/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
}

.components-tooltip .components-popover__content {
padding: $grid-unit-05 $grid-unit-10;
background: $dark-gray-primary;
border-radius: $radius-block-ui;
border-width: 0;
Expand All @@ -17,6 +16,10 @@

// This prevents quickly hovering the tooltip from blocking hovering something else.
pointer-events: none;

> div {
padding: $grid-unit-05 $grid-unit-10;
}
}

.components-tooltip__shortcut {
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-post/src/components/header/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
}

.edit-post-post-preview-dropdown {
.components-popover__content {
.components-popover__content > div {
padding-bottom: 0;
}
}
4 changes: 3 additions & 1 deletion packages/editor/src/components/table-of-contents/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@

.table-of-contents__popover {
.components-popover__content {
padding: $grid-unit-20;
> div {
padding: $grid-unit-20;
}

@include break-small {
max-height: calc(100vh - 120px);
Expand Down
4 changes: 3 additions & 1 deletion packages/format-library/src/text-color/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
.components-inline-color-popover {

.components-popover__content {
padding: 20px 18px;
> div {
padding: 20px 18px;
}

.components-color-palette {
margin-top: 0.6rem;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
.list-reusable-blocks-import-dropdown__content .components-popover__content {
.list-reusable-blocks-import-dropdown__content .components-popover__content > div {
padding: 10px;
}
5 changes: 4 additions & 1 deletion packages/nux/src/components/dot-tip/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,12 @@ $dot-scale: 3; // How much the pulse animation should scale up by in size
}

.components-popover__content {
padding: 5px (36px + 5px) 5px 20px;
width: 350px;

> div {
padding: 20px 18px;
}

@include break-small {
width: 450px;
}
Expand Down