Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover block - update copy for Opacity label #23287

Merged
merged 1 commit into from
Jun 21, 2020

Conversation

bartczyz
Copy link
Contributor

Description

Remove 'background' word from "Background Opacity" label in Cover block.

Closes #23056.

Types of changes

Just label update, no change in functionality of the component.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@bartczyz bartczyz changed the title update copy for Opacity label Cover block - update copy for Opacity label Jun 18, 2020
@ZebulanStanphill ZebulanStanphill added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Package] Block library /packages/block-library [Type] Copy Issues or PRs that need copy editing assistance labels Jun 18, 2020
@bartczyz
Copy link
Contributor Author

@ZebulanStanphill thanks for approving the PR. Do I have to take any action related to Travis CI? The error seems to be not related to Cover block.

@ZebulanStanphill
Copy link
Member

@bartczyz There have been some issues with end-to-end tests lately (which still aren't fully resolved). Try rebasing the branch to restart tests.

Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restarted the tests, they are green now.

@Soean Soean merged commit 49d6086 into WordPress:master Jun 21, 2020
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 21, 2020
This was referenced Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Package] Block library /packages/block-library [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is an Overlay Opacity and not a Background Opacity
3 participants