Fix React warning while unmounting slots #23365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
Size Change: +120 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Jun 22, 2020
youknowriad
force-pushed
the
fix/react-warning
branch
from
77407fc to
a545d50
Compare
youknowriad
force-pushed
the
fix/react-warning
branch
from
a545d50 to
8dad18a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #17355
closes #23355
Ideally, we'd move forward with the new implementation of Slot/Fill #22027 (but we'd need mobile folks help with that to ensure there's a fallback for native cc @Tug). In the meantime, this is a small fix to the React warning we get each time we focus on a new RichText.