Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Library i18n: use __() to make the string translatable #24075

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Block Library i18n: use __() to make the string translatable #24075

merged 1 commit into from
Jul 21, 2020

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Jul 20, 2020

Description

This PR adds the missing __() call to a strings to make it translatable..

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@Soean Soean added Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended labels Jul 21, 2020
@Soean
Copy link
Member

Soean commented Jul 21, 2020

Good catch, thanks for the fix.

@Soean Soean merged commit 6818490 into WordPress:master Jul 21, 2020
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 21, 2020
@github-actions github-actions bot added this to the Gutenberg 8.7 milestone Jul 21, 2020
@ramiy ramiy deleted the patch-2 branch July 22, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soean Soean Soean approved these changes

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 8.7
Development

Successfully merging this pull request may close these issues.
2 participants
@ramiy @Soean