Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global styles sidebar at edit site screen #24250
Add global styles sidebar at edit site screen #24250
Changes from all commits
4c50a5f
c3d26b1
54c6116
6ae71b6
4e96c1c
495be14
0d88467
6be29f1
0b952d7
00c6126
25cfb3a
ac89dcf
c0ef0b3
4c1e497
62ded6b
ac655f5
0c4e8dc
31a8b1a
f0b0293
56850d5
f69f437
3c9b3a6
7bc6cb7
3581e1f
7b30c5d
a57df47
43fae0b
a2c0860
c045d88
554a857
d7392b5
3ad9f9b
8a4667b
91ede60
db6c9dc
072e5f4
7cd35cd
f55fe3e
7d4389d
e10e375
02af322
33f20d4
584c145
a5bb681
279eadc
03fad42
cd55f33
cdda0e2
8ec4ca0
f16b7ac
f73e2bb
3ceeac7
ac1dadd
9d7abcf
c97540c
8025a07
6a347b3
ffce3e6
2819d1b
48ab467
36f55a3
43d4dab
5d38eb0
6a180f1
4f56221
80b38a7
510181f
602920f
09dc3d9
c511af2
30b8bcf
027db4d
dae9269
6dfc7e5
422a359
43a6f12
63dc5f1
16ed391
fbbac37
3491e92
0248802
b90617e
76a68c3
20fcaaa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker but I think when we start having many styles rendering every rule on each global style attribute change is going to be very costly. I wonder if we can avoid rerendering the rules that don't have any attribute changed. It is essentially what react does only render things on the dom when in fact the vdom of that node changed. I wonder if we can use react itself to do that for us. Maybe using multiple style elements that are rendered with react?
Anyway, it is just an idea to explore later.