Prefix useSimulatedMediaQuery __experimental #24279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
12 tasks
|
Size Change: +2 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
tellthemachines
added
the
Backport to WP 6.7 Beta/RC
talldan
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
Looks good.
I noticed the linked conversation (#23669 (comment)) mentioned making it unstable, experimental seems ok too, but it might be worth documenting why in the PR.
|
Experimental = we plan to stabilise it |
|
Are we ok changing that today without ensuring at least 2 releases backward compatibility in the plugin? |
|
The alternative being that we just return the string untouched if we deprecate it? |
|
yes, something like that. searching on wpdirectory.net it seems it's not being used by third-party code. So I'm fine either way. |
youknowriad
pushed a commit
that referenced
this pull request
Aug 3, 2020
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
__experimentalprefix touseSimulatedMediaQuery.How has this been tested?
Tested locally to make sure the function still works.
Screenshots
Types of changes
Checklist: