Announce block selection changes manually on windows #24299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
commented
Jul 30, 2020
| // See WordPress/gutenberg#24121 and nvaccess/nvda#5825 for more details | ||
| // To solve it we announce the focus change manually. | ||
| if ( isWindows() ) { | ||
| speak( label ); |
There was a problem hiding this comment.
I also wondered whether I should announce something like label + ', button'
There was a problem hiding this comment.
I think label is good enough.
|
Size Change: +27 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
approved these changes
Aug 3, 2020
| // See WordPress/gutenberg#24121 and nvaccess/nvda#5825 for more details | ||
| // To solve it we announce the focus change manually. | ||
| if ( isWindows() ) { | ||
| speak( label ); |
There was a problem hiding this comment.
I think label is good enough.
youknowriad
added a commit
that referenced
this pull request
Aug 3, 2020
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #24121
In NVDA on Windows, the block selection changes are not announced properly on Navigation Mode (Gutenberg's navigation mode).
As discussed on the issue, this solves the issue by announcing the blocks manually.