Try sliding toolbar for overflow on mobile #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR may fix #2287, at least partially, or in a transitional way. It's a two-line code change, and all it does is ensure that on mobile, overflow can be scrolled. This is not a good solution for desktop, of course, where the scrollbar when visible (as it is on nearly all computers) would not only cover content and be ugly, but scrolling horizontally is generally not a good experience. However on mobile, the scrollbar fades in briefly when you load the page, and you can just drag with your finger. Let's discuss whether this is a good solution.
jasmussen
added
General Interface
|
Here's how the Android app does it: https://cloudup.com/c9O9cRkfx0K |
|
Merging because the tests pass, it's a trivial change, and I got a thumbs up in chat! |
|
Right, the only way I can see to make the drop-down menu work again is to set the position using Javascript. |
|
Because it relied on being able to position relative to the button and now the button does not allow any overflow. The only reason the block switcher still works is that it always ignored the position of the button when displaying the drop-down. |
|
Going to try something, I have an idea. |
BoardJames
pushed a commit
that referenced
this pull request
Aug 22, 2017
This was referenced Aug 22, 2017
BoardJames
pushed a commit
that referenced
this pull request
Aug 29, 2017
…-overflow-none Fix bug introduced by #2443 where drop-down menu can't display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR may fix #2287, at least partially, or in a transitional way. It's a two-line code change, and all it does is ensure that on mobile, overflow can be scrolled.
This is not a good solution for desktop, of course, where the scrollbar when visible (as it is on nearly all computers) would not only cover content and be ugly, but scrolling horizontally is generally not a good experience. However on mobile, the scrollbar fades in briefly when you load the page, and you can just drag with your finger.
Let's discuss whether this is a good solution.
Demo: