Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: make a string translatable inside large-header-button pattern #24499

Merged
merged 2 commits into from
Aug 13, 2020
Merged

i18n: make a string translatable inside large-header-button pattern #24499

merged 2 commits into from
Aug 13, 2020

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Aug 11, 2020 •
edited
Loading

Description

Make the "Read now" string translatable.

Fixes: https://core.trac.wordpress.org/ticket/50904

Reported by yoavf.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@Soean Soean added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Aug 12, 2020
Soean
Soean approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ramiy
Copy link
Contributor Author

ramiy commented Aug 13, 2020

Current:

Read now

New:

__( 'Read now', 'gutenberg' )

@Soean Soean merged commit 4ff9709 into WordPress:master Aug 13, 2020
@github-actions github-actions bot added this to the Gutenberg 8.8 milestone Aug 13, 2020
@ItsJonQ ItsJonQ mentioned this pull request Aug 17, 2020
Closed
@ramiy ramiy deleted the patch-2 branch August 26, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soean Soean Soean approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Milestone
Gutenberg 8.8
Development

Successfully merging this pull request may close these issues.
2 participants
@ramiy @Soean