-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix canInsertBlockType selector returning true for blocks that don't allow inner blocks #24514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t support inner blocks
talldan
added
[Type] Bug
An existing feature does not function as intended
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
[Feature] Drag and Drop
Drag and drop functionality when working with blocks
[Package] Block editor
/packages/block-editor
labels
Aug 12, 2020
Size Change: +8 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Drag and Drop
Drag and drop functionality when working with blocks
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
[Package] Block editor
/packages/block-editor
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #23952, I noticed
canInsertBlockType
will returntrue
for block types that don't support inner blocks.For example, running
canInsertBlockType
withcore/paragraph
as the first argument and the client id of another paragraph as the second argument returnstrue
, indicating a paragraph can be nested under a paragraph.I think this hasn't ever been a problem because this selector wouldn't have been used on a paragraph. It's perhaps only used within the
InnerBlocks
component.For List View, the blocks in the list don't render
InnerBlocks
, so I needed to be able to determine if a block like a paragraph could support inner blocks outside of that context.Code changes
When a block supports Inner Blocks, an object is added to
blockListSettings
for its clientId. This PR uses that implementation detail to determine if a blocks supports inner blocks. If that value isundefined
,false
is returned.This meant updating a few tests that made the assumption no value would be stored in
blockListSettings
for a block that supports inner blocks.How has this been tested?
_clientId_
:e.g.:
false
is returned.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: