-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: Export Editor component #24524
Conversation
Size Change: +7 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. Maybe should also get a ✅ from @youknowriad
cc/ @saramarcondes |
Can you clarify more how is this package used in alternative JS apps. If we're making this an API we need to understand how to maintain backward compatibility for it. In general we consider |
@ockham @youknowriad is right. I'm running into this currently trying to use |
@saramarcondes Oh, did my suggestion about using |
@ockham Ah, I haven't had a change to try that out yet, I didn't realize that it could be a wholesale solution to this but now I'm realizing what you mean. Do you think that's the best approach to being able to use these components outside of wp admin though? I think I'd prefer actually spending some time to develop an API for it rather than doing something that is admittedly kind of a hack. It seems like it would be a nightmare to maintain longterm and even less intuitive/more stuff to explain to a new dev coming into the area. |
Yeah, that's a fair point. My main goal here is to control the |
Description
Export the Editor component from the
@wordpress/edit-site
package. This will allow us to embed that component in different JS apps.How has this been tested?
Doesn't really need testing.
Types of changes
New export.
Checklist: