Fix settings name #25040
Merged
Fix settings name #25040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
approved these changes
Sep 3, 2020
|
Yes, these color components are so complex. At some point we need to make an audit and simplify things, remove unused experimental APIs... |
|
Size Change: -4 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the setting name introduced at #24964
This is a bug I couldn't reproduce, so I'm going to call it a dormant bug. What happens is that the
ColorGradientControlpulls the data from the store if their ancestors don't pass it as props. I could check that this never happens in practice. These are the two ancestors that use the control:PanelColorGradientSettingsInner=> retrieves on its own the settings from the store and pass them toColorGradientControl.ColorPaletteControl=> I haven't found this component in use anywhere.A related question is whether it should be the
ColorGradientControlresponsibility to pull this data or let their ancestors configure it via props, as they already do the same. However, that's a separate discussion, so I think we should just fix this at the moment.