Avoid relying on DOM events to measure the loading time #25288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Automated Testing
youknowriad
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
|
let's try this. the current numbers are broken anyway. |
|
BTW should we disable Puppeteer cache before Maybe this would give more representative numbers for perf tests? |
|
@ockham seems like a good improvement yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the update to the last React version, the initial rendering of the editor became "lazy". This means the "load" and "domcontentloaded" events are no longer good indicators to measure the loading performance of the editor. This PR updates the performance tests to rely on a timer that stops when the first block is rendered.