fix undefined index notice in Social Link Block #25663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
ntsekouras
reviewed
Sep 28, 2020
| @@ -15,7 +15,7 @@ | |||
| * @return string Rendered HTML of the referenced block. | |||
| */ | |||
| function render_block_core_social_link( $attributes, $content, $block ) { | |||
| $open_in_new_tab = $block->context['openInNewTab']; | |||
| $open_in_new_tab = array_key_exists( 'openInNewTab', $block->context ) ? $block->context['openInNewTab'] : false; | |||
There was a problem hiding this comment.
Why not use isset here like the rest of code? I think that way you wouldn't have problems even if $block-context doesn't exist.
There was a problem hiding this comment.
It would be great to update and land this PR, I saw this notice recently.
There was a problem hiding this comment.
@gziolo Thanks for putting the note here. I just updated the PR :)
gziolo
added
[Type] Code Quality
mkaz
force-pushed
the
feature/25455-add-option-open-in-new-tab
branch
from
39dcfaf to
1eb898a
Compare
talldan
added
the
Backport to WP 6.7 Beta/RC
|
This seems like it should also be in 5.6, so I've added the backport label. |
tellthemachines
pushed a commit
that referenced
this pull request
Nov 11, 2020
* fix undefined index notice * use isset instead of array_key_exists check * Update packages/block-library/src/social-link/index.php Co-authored-by: Greg Ziółkowski <[email protected]> Co-authored-by: Greg Ziółkowski <[email protected]>
6 tasks
tellthemachines
added a commit
that referenced
this pull request
Nov 12, 2020
* Cover block: Restore default overlay background (#26569) * Restore default Cover overlay background The default Cover block overlay background was removed. This changed the style of existing blocks on existing sites. Restore the default background in such a way that it does not conflict with theme-provided background-color styles and there is no need to artificially add extra specificity. Fix regression: #26545 * Limit the interface skeleton to a max width of 100% to prevent some blocks managing to exceed the width (#26552) * Cover Block: Restore opacity controls (#26625) * Fix image block centering when resizing to a smaller size (#26376) * Fix image block centering when resizing to a smaller size * Revert previous 100% width fix * Remove display: table when image block is resized to avoid centering of block * Match frontend classes for alignment in editor * Gallery: Remove caption fallback for alt attribute (#26676) * Fix quote block default alignment (#26680) * Gallery: Remove obsolete deprecation entry (#26736) * Do not apply text color if it is being overriden (#24626) * Fix: Preset colors don't work on button block style outline (#26707) * Tests: Add fixture for Column deprecation (#26774) * Fix/column width units (#26757) * Fix issues with different units in column widths * Columns with fixed width should keep width on recalculation * Address review feedback * fix undefined index notice in Social Link Block (#25663) * fix undefined index notice * use isset instead of array_key_exists check * Update packages/block-library/src/social-link/index.php Co-authored-by: Greg Ziółkowski <[email protected]> Co-authored-by: Greg Ziółkowski <[email protected]> * Adds in missing styling for toolbar when using text-only setting (#26769) * Adds in missing styling for toolbar when using text-only setting * Increases margin * Moves style to correct file * Inserter: Fix 'Browse All' in Quick Inserter (#26443) * Inserter: Fix 'Browse All' in Quick Inserter Maintain the insertion point in @wordpress/block-editor state when moving from the Quick Inserter to the Inserter. This fixes a bug where the insertion point is wrong after clicking a block appender and selecting 'Browse All'. Care is taken to not regress a previous bug where the insertion point is wrong after clicking an inline insertion button and selecting 'Browse ALl'. * Inserter: Fix typo Co-authored-by: Daniel Richards <[email protected]> * Call getBlockInsertionPoint once * Add useSelect dependencies * Make setInsertionPoint unstable * Avoid setting `isVisible` state when `SET_INSERTION_POINT` is triggered * Make index required and clarify rootClientId usage * Split insertionPoint into two reducers * Fix getInsertionPoint selector that expects default state of reducer to be null * Avoid resetting insertionPoint state on HIDE_INSERTION_POINT Co-authored-by: Daniel Richards <[email protected]> Co-authored-by: Jon Surrell <[email protected]> Co-authored-by: Jacopo Tomasone <[email protected]> Co-authored-by: Daniel Richards <[email protected]> Co-authored-by: Bernie Reiter <[email protected]> Co-authored-by: Greg Ziółkowski <[email protected]> Co-authored-by: Oliver Juhas <[email protected]> Co-authored-by: Jorge Costa <[email protected]> Co-authored-by: Fabian Kägy <[email protected]> Co-authored-by: Tammie Lister <[email protected]> Co-authored-by: Robert Anderson <[email protected]>
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to #25468. @afercia found that there is an error that throws undefined notices: #25468 (comment)
This PR addresses that.