-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Links: Avoid conflict with themes ul text-indent #25916
Conversation
@enriquesanchez or @aleone89 Can you confirm that this fixes the issue reported in #20893 ? |
Size Change: +15 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
1cba97d
to
9c957bb
Compare
The social links could pick up the text-indent from some themes global <ul> settings. This explictly sets the social link text-indent to 0
9c957bb
to
d718efb
Compare
Hi @mkaz! I can confirm that this fixes the indent conflict. That said, I was no longer able to reproduce the issue in #20893. With or without this PR, the social links looked OK on the front-end.
Maybe that is why? |
@enriquesanchez yep, the other margin fixes is already in place. The Jetpack issue reported with regards to text-indent was attached to that original issue, so I kept it open. So once approved and merged this PR will close it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mkaz! This looks good to me 👍
Description
The social links could pick up the text-indent from some themes global
<ul>
settings.This explictly sets the social link text-indent to 0
Fixes #20893
How has this been tested?
<ul>
text-indent (or modify in inspector)Screenshots
Types of changes