Update media-text focalPoint conditional rendering. #25968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
<FocalPointPicker />
has an explicit dependency ofimageFill
, but also an implicit dependency ofmediaUrl
, which may result in an empty<FocalPointPicker />
whenimageFill
is enabled by default in an<InnerBlock />
template.This change includes an explicit check for
mediaUrl
, in addition toimageFill
, so that the<FocalPointPicker />
does not render empty.How has this been tested?
Having a custom block using an
<InnerBlock />
template which includes themedia-text
block withimageFill
set totrue
.Insert the custom block, which will not have an image set.
The focal point setting in the sidebar is not rendered.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: