Give editable fields in blocks better aria-labels. #26582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Bug
ZebulanStanphill
requested review from
ajitbohra,
ajlende,
mkevins,
Soean and
talldan
as code owners
|
Size Change: +224 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
It looks like this PR needs testing and should be good to go. |
ZebulanStanphill
force-pushed
the
fix/1659
branch
from
4ece1df to
f1f471d
Compare
ZebulanStanphill
force-pushed
the
fix/1659
branch
from
f1f471d to
8e76797
Compare
gziolo
reviewed
Nov 19, 2020
| @@ -23,6 +23,7 @@ export default function ShortcodeEdit( { attributes, setAttributes } ) { | |||
| className="blocks-shortcode__textarea" | |||
| id={ inputId } | |||
| value={ attributes.text } | |||
| aria-label={ __( 'Shortcode text' ) } | |||
There was a problem hiding this comment.
"text" might be not the best fit for shortcodes. How about 'Shortcode content'?
There was a problem hiding this comment.
"Content" sounds like it might refer to stuff between shortcode tags, but not including them, so I'm not sure if it's the right term. What do you think, @afercia?
gziolo
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Proposed changes look good 👍
Ideally, it should be tested by someone using assistive technologies before merging.
I also included some suggestions for placeholder props to align with the most popular usage. Totally optional, I leave it up to you to decide whether they make sense to apply 😄
Co-authored-by: Greg Ziółkowski <[email protected]>
ZebulanStanphill
force-pushed
the
fix/1659
branch
from
b9650e1 to
fc7545b
Compare
|
Thank you @ZebulanStanphill for addressing my feedback, feel free to merge based on my review if there is no more feedback added 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1659.
Checklist: