Add inserter performance measures #26634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
added
[Status] In Progress
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
david-szabo97
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
That's very cool. Can we add these measures to the performance command output ( |
|
Thanks for the updates, that looks better. That said, I wonder if we should split the outputted table somehow, it's becoming unreadable unless you have a giant screen.
Or maybe we should remove the "min/max" values from all measures in the output? |
How about inverting the table? |
|
That's a lot better thanks. |
|
Looking at the numbers inserterOpened is changing by 10ms seconds above without any change in the code. Do you think this is within the range of error? Anything we can do to make the number more stable so we can trust it better? |
youknowriad
approved these changes
Nov 9, 2020
|
So far I saw a maximum of 3% difference between runs. I think ~10ms (~2.5%) is fine here. |
One option is to take multiple before and after measurements, and applying a Welch's t-test to calculate a p-value. With that, you can determine whether the change is significant or just a statistical blip. I wrote a tool that does this for basic page metrics (not SPA interaction like you need here), but the code might still help: https://github.com/Automattic/lab-assistant |
david-szabo97
force-pushed
the
try/inserter-perf-measures
branch
from
ac3f077 to
a071206
Compare
david-szabo97
removed
the
[Status] In Progress
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add two new performance measurements:
How has this been tested?
npm run test-performanceScreenshots
Types of changes
New feature
Checklist: