Remove .block-editor selector dependency #27063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as they should be editor agnostic.
this is also used in some blocks (file, HTML, shortcode).
oandregal
requested review from
ajitbohra,
ellatrix and
talldan
as code owners
oandregal
added
[Package] Block library
|
Size Change: -153 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
This was referenced Nov 18, 2020
Copons
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10783
In #26958 it was reported that some blocks don't behave properly in edit-site regarding its styles. The issue is that they depend on the
.block-editorselector that is only present in the post editor, but not in edit site, widgets, or navigation.We can either remove that dependency from blocks or add the class to all editors. This PR removes that dependency.
The blocks that are directly affected are: archives, categories, latest-posts, more, rss, shortcode, tag-cloud.
This also removes the class from the plain-text component, which affects to the following blocks: file, HTML, shortcode.
How to test