Drop zone provider: option to avoid wrapper element #27079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +79 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/drop-zone-provider
branch
from
39074a6 to
0e282eb
Compare
ellatrix
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
ellatrix
force-pushed
the
try/drop-zone-provider
branch
from
0e282eb to
84a9569
Compare
ellatrix
force-pushed
the
try/drop-zone-provider
branch
from
fc97655 to
ed23aec
Compare
|
Hey @ellatrix - this PR seems to have caused some regressions about The problem is that when you have opened the |
|
I tried reverting this PR (had to change two lines manually, but that was quite straight-forward), but the problem still seems to persist for me 😕 (Experimental PR here: #29516) |
Weird 🤔 - git bisected in a wrong way :) ? I think @ellatrix will have better input for this... This line here is the one that enables both drop zones to be active, even if they are not visible. |
|
Looking at this today |
|
I'm not sure how drag and drop into the media library and content are related? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the drop zone provider has two purposes:
The element is not strictly necessary, so the latter purpose could be isolated behaviour in a hook, while the former could be purely a context provider.
Why? While it's always good to separate pieces of functionality and remove unnecessary div wrappers, this separation makes it also easier to implement iframing the editor content. With the drop behaviour separated, we can call it within the iframe on the body element.
I marked the new provider and hook unstable for now. I have some more thoughts on how we could potentially avoid the context and behaviour hook altogether if we manage to built it into the drop zones themselves. This requires some time to explore though.
How has this been tested?
Screenshots
Types of changes
Checklist: