Verse Block: Adds support for custom padding #27341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
requested review from
ajitbohra,
chrisvanpatten,
mkaz and
talldan
as code owners
|
Size Change: +382 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Nov 27, 2020
|
One unit test fails, running |
|
I tried to test with: <!-- wp:verse {"style":{"typography":{"fontFamily":"var:preset|font-family|system"}}} -->
<pre class="wp-block-verse" style="font-family:var(--wp--preset--font-family--system)">This is my styled verse</pre>
<!-- /wp:verse -->
<!-- wp:verse -->
<pre class="wp-block-verse">This is unstyled verse
</pre>
<!-- /wp:verse -->One thing that wasn't clear to me is how do I enable custom padding for the theme. If the theme doesn't have the support for custom padding this default value is ignored which feels like a good thing. I figured out that the theme needs to call: add_theme_support( 'custom-spacing' );With that added, I was able to test how the test content behaves and it works perfectly fine. Feel free to merge this PR after the rebase. |
scruffian
force-pushed
the
update/verse-block-padding
branch
from
7c39a3a to
2ba1a4c
Compare
oandregal
reviewed
Dec 3, 2020
oandregal
reviewed
Dec 3, 2020
oandregal
reviewed
Dec 3, 2020
| @@ -342,6 +342,7 @@ These are the current color properties supported by blocks: | |||
| | --- | --- | | |||
| | Cover | Yes | | |||
| | Group | Yes | | |||
| | Verse | Yes | | |||
|
I tried regenerating the fixtures again but it failed. Do I need to add a depreaction? |
|
Tried to re-run the tests but something went wrong, not sure what. Could you try to rebase from master and push again so the CI jobs are restarted? |
scruffian
force-pushed
the
update/verse-block-padding
branch
from
f85d969 to
0b9a7e4
Compare
|
I rebased but the tests failed again. |
Co-authored-by: O André <[email protected]>
Co-authored-by: O André <[email protected]>
scruffian
force-pushed
the
update/verse-block-padding
branch
from
0b9a7e4 to
ab44b59
Compare
guarani
added a commit
that referenced
this pull request
Dec 7, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for custom padding to the Verse block. Also adds a default of 20px to match the padding that the editor adds. We might decide that to remove this padding.
How has this been tested?
Tested in TT1 Blocks in Chrome.
Screenshots
Types of changes
New feature
Checklist: