Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusts settings modal height to 90% #27362

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Adjusts settings modal height to 90% #27362

merged 1 commit into from
Dec 2, 2020

Conversation

grzim
Copy link
Contributor

@grzim grzim commented Nov 29, 2020 •
edited
Loading

Description

Modal size has been improper - modal displayed too little content.
In issue #22854 it was proposed to change the height to 90%

How has this been tested?

Tested visually (minor css fix)

Screenshots

https://d.pr/free/i/lpTXeU

Types of changes

CSS fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

draganescu
draganescu approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@draganescu draganescu changed the title according to issue 22854 modal height has been changed to 90% Adjusts settings modal height to 90% Nov 30, 2020
@draganescu draganescu merged commit d3eb793 into WordPress:master Dec 2, 2020
@github-actions github-actions bot added this to the Gutenberg 9.6 milestone Dec 2, 2020
This was referenced Dec 9, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 9.6
Development

Successfully merging this pull request may close these issues.
2 participants
@grzim @draganescu