Update: Global Styles: Do not pass selectors and supports information to the client #27449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
jorgefilipecosta
added
the
Global Styles
|
Size Change: +1.71 kB (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
update/global-styles-do-not-pass-selectors-and-supports-to-the-client
branch
from
21a5830 to
356ec04
Compare
oandregal
reviewed
Dec 3, 2020
jorgefilipecosta
changed the title
Co-authored-by: O André <[email protected]>
jorgefilipecosta
deleted the
update/global-styles-do-not-pass-selectors-and-supports-to-the-client
branch
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added logic on the client to compute the selectors and supports for each context but we continued to pass this information anyway from the server without it being used.
This PR applies a refactor to the server code so that selectors and supports are not part of the global styles tree. On the client, they are not so this improves the match between the client and server code.
How has this been tested?
I verified using the devtools that the __experimentalGlobalStylesBaseStyles setting now does not contains selector and supports information.
I verified things continued to work and the styles continued to be generated as expected.