Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport for WP 5.6 RC3 #27454

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Backport for WP 5.6 RC3 #27454

merged 1 commit into from
Dec 3, 2020

Conversation

tellthemachines
Copy link
Contributor

Description

Backport Try fixing combobox a11y issues #27431

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@tellthemachines
Try fixing combobox a11y issues (#27431)
97a3ec2 
* Fix label announcement on VoiceOver

* Try to fix selection announcement

* Revert commented line.
@tellthemachines tellthemachines merged commit c29fb7f into wp/5.6 Dec 3, 2020
@tellthemachines tellthemachines deleted the wp/5-6-rc-3 branch December 3, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin940726 kevin940726 kevin940726 approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@youknowriad youknowriad Awaiting requested review from youknowriad youknowriad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tellthemachines @kevin940726