Block editor: move block focus listener to block props hook #27463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +11 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/block-focus
branch
from
8dd62f6 to
d81417d
Compare
ellatrix
force-pushed
the
try/block-focus
branch
from
cb955bb to
e3bbf1b
Compare
ellatrix
commented
Dec 3, 2020
| const clientId = getBlockClientId( event.target ); | ||
|
|
||
| if ( clientId && clientId !== selectedBlockClientId ) { | ||
| selectBlock( clientId ); |
There was a problem hiding this comment.
Previously a client ID from a reusable block list would be set to the main store, which is a bug. The reusable block should handle this behaviour by clearing the selected block in the main store.
|
This breaks the Legacy Widget block. You can no longer select it in the widgets editor and e.g. see the block toolbar appear. |
|
Will look into it today. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This essential logic belongs in the block itself rather than on the root container. In the block we have access to the client ID without having to query the DOM.
Eventually, it would be good to get rid of the root container.
How has this been tested?
Screenshots
Types of changes
Checklist: