Update the backup icon to better align with WordPress icon package dna #27465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
|
Size Change: +831 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
I like that the circle's line-width now matches better with the other icons. But, the clock hands being triangular really bug me; Why not just use lines? |
|
Here's a couple of other options that use lines for the hands. The first one uses an identical arrow to the
Figma link here in case anyone would like to play with these. |
|
@jameskoster I'm really digging that first one in the last set. The arrow feels more defined and the hands look good, although seem to reflect a checkmark. 🤔
|
|
I'd agree with Shaun, the triangular arrows don't really share DNA with the new icon set. However we have htis icon for rotate, that you could take inspiration from:
Here's the time machine icon:
The ingredients in use there seem to get the balance right. |
That is precisely what the icon is based on, it's the same arrow just tidied up a bit 😆 Here's a version that is – ahem – loosely inspired by the Time Machine icon:
In context:
|
|
I think that one works. 👍 👍 |
jasmussen
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the current backup icon – used in the "Revisions" link – is based on an old Dashicon. This PR updates it to match the other icons in the WordPress Icons package, namely:
Before:
After:
Rotate icon for reference:
Additional considerations:
The new icon is a 1:1 match with the rotate icon, just rotated slightly to make room for the "hands" of the "clock". If we break that 1:1 relationship ever so slightly we get a sharper icon.
So there's a question to be asked around sharpness vs consistency. Thoughts?
To test: