-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: Use a build matrix for the e2e tests GH action #27487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Status] In Progress
Tracking issues with work in progress
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
[Package] E2E Tests
/packages/e2e-tests
labels
Dec 3, 2020
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
ockham
requested review from
youknowriad,
sirreal,
WunderBart,
fullofcaffeine,
gziolo and
ntsekouras
December 3, 2020 21:59
sirreal
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a nice simplification and appears to be working well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] E2E Tests
/packages/e2e-tests
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The e2e tests GH action currently consists of 4 jobs, which all share the exact same code, except for one bit: Each of them only runs 1/4 of the available tests.
This PR de-duplicates the code by introducing a build matrix that's used by the remaining job.
(This might also cut down on build time.)
How has this been tested?
Verify that the "Admin - 1" to "Admin - 4" GH actions are still present for this PR. Verify that each of them runs a different set of e2e tests.