Make the inserter in the site editor behave as a popover #27502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Focus] Accessibility (a11y)
youknowriad
commented
Dec 4, 2020
| @@ -0,0 +1,57 @@ | |||
| /** | |||
There was a problem hiding this comment.
This file is duplicated between edit-post and edit-site. Separately, I'd like to factorize that and transform it to a React hook in @wordpress/compose if possible.
There was a problem hiding this comment.
That sounds a good idea 👍
There was a problem hiding this comment.
Actually it's used in edit-widgets as well, so it's triplicate.
|
I haven't had a chance to follow too deeply with the discussions here, so I only vaguely recall a conversation about this behavior on another ticket, which of course I can't find. I CC'ed a couple of people in case they have context for whether this was intentional or not. |
|
Size Change: +335 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Dec 4, 2020
youknowriad
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
youknowriad
force-pushed
the
fix/inserter-popover-edit-site
branch
2 times, most recently
from
ccd4848 to
bba31d3
Compare
youknowriad
force-pushed
the
fix/inserter-popover-edit-site
branch
from
bba31d3 to
745f3ac
Compare
This was referenced Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the behavior of the inserter in the post editor and fixes some a11y issues for the inserter (constrained tabbing, closes when the focus is outside...)