Fixes the width on the circle color picker popover #27523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapk
added
the
[Feature] UI Components
|
Size Change: +20.9 kB (1%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
shaunandrews
reviewed
Dec 4, 2020
| @@ -4,6 +4,7 @@ $color-palette-circle-spacing: 12px; | |||
| .components-circular-option-picker { | |||
| display: inline-block; | |||
| width: 100%; | |||
| min-width: 244px; | |||
There was a problem hiding this comment.
I can confirm this fixes things, but I wonder where 244px came from?
There was a problem hiding this comment.
I'm not sure we have a set width for these... they change from one to another. So with this one, I made the width 244px + the additional popover padding which equates to 280px. And 280px is the same as the Sidebar Settings.
There was a problem hiding this comment.
Thats probably fine; It fixes the immediate problem.
That said, I worry this might look strange if there's only 2-3 color swatches; It could lead to some awkward whitespace.
|
I fiddled a bit with the width to accommodate an even spread of circles and still have it visually descent for a small number of colors. Here's where I landed. With many circles
With two circles
|
shaunandrews
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27522.
Sets a min-width on the circle color picker.
How has this been tested?
Locally.
Screenshots
BEFORE
AFTER
Types of changes
Non-breaking CSS changes.
Checklist: