Block editor: merge RootContainer with BlockList #27531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Dec 6, 2020
| function BlockList( | ||
| { className, placeholder, rootClientId, renderAppender }, | ||
| ref | ||
| ) { | ||
| const Container = rootClientId ? 'div' : RootContainer; |
There was a problem hiding this comment.
rootClientId will always be falsy since InnerBlocks doesn't use this component anymore.
There was a problem hiding this comment.
When did InnerBlocks stop using this component?
|
Size Change: +38 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
remove/root-container
branch
from
6936ca3 to
e953372
Compare
ellatrix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This component was introduced for adding logic to the root of nested block lists, but since
InnerBlocksis no longer usingBlocksListbut ratherBlockListItemsdirectly (see #25633), there's no need anymore to have a separate component becauseBlockListis the root container.How has this been tested?
Screenshots
Types of changes
Checklist: