Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Babel packages to 7.12.x #27553

Merged
merged 5 commits into from
Dec 8, 2020
Merged

Upgrade Babel packages to 7.12.x #27553

merged 5 commits into from
Dec 8, 2020

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Dec 7, 2020

Needed by the webpack 5 upgrade in #26382, as the 7.12 version includes fixes for Babel helper ESM imports from babel/babel#10853.

@jsnajdr jsnajdr added the [Type] Build Tooling Issues or PRs related to build tooling label Dec 7, 2020
@jsnajdr jsnajdr requested review from sgomes and gziolo December 7, 2020 14:24
@jsnajdr jsnajdr self-assigned this Dec 7, 2020
@github-actions
Copy link

github-actions bot commented Dec 7, 2020 •
edited
Loading

Size Change: -82 B (0%)

Total Size: 1.21 MB

Filename Size Change
build/block-editor/index.js 128 kB +40 B (0%)
build/block-library/index.js 149 kB +31 B (0%)
build/block-library/style-rtl.css 8.35 kB +6 B (0%)
build/block-library/style.css 8.35 kB +4 B (0%)
build/components/index.js 172 kB -5 B (0%)
build/components/style-rtl.css 15.3 kB -2 B (0%)
build/components/style.css 15.3 kB -2 B (0%)
build/core-data/index.js 15.4 kB +5 B (0%)
build/edit-navigation/index.js 11.1 kB +8 B (0%)
build/edit-post/index.js 306 kB -7 B (0%)
build/edit-site/index.js 24.7 kB -1 B
build/edit-widgets/index.js 26.3 kB -4 B (0%)
build/editor/index.js 43.4 kB -155 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.8 kB 0 B
build/api-fetch/index.js 3.42 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/index.js 8.72 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 11.2 kB 0 B
build/block-editor/style.css 11.2 kB 0 B
build/block-library/editor-rtl.css 9.07 kB 0 B
build/block-library/editor.css 9.07 kB 0 B
build/block-library/theme-rtl.css 789 B 0 B
build/block-library/theme.css 790 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/compose/index.js 10.1 kB 0 B
build/data-controls/index.js 827 B 0 B
build/data/index.js 8.97 kB 0 B
build/date/index.js 31.8 kB 0 B
build/deprecated/index.js 769 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.95 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/style-rtl.css 6.49 kB 0 B
build/edit-post/style.css 6.47 kB 0 B
build/edit-site/style-rtl.css 3.93 kB 0 B
build/edit-site/style.css 3.93 kB 0 B
build/edit-widgets/style-rtl.css 3.13 kB 0 B
build/edit-widgets/style.css 3.13 kB 0 B
build/editor/editor-styles-rtl.css 476 B 0 B
build/editor/editor-styles.css 478 B 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.62 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 6.74 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.27 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 698 B 0 B
build/keyboard-shortcuts/index.js 2.54 kB 0 B
build/keycodes/index.js 1.93 kB 0 B
build/list-reusable-blocks/index.js 3.1 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.31 kB 0 B
build/notices/index.js 1.82 kB 0 B
build/nux/index.js 3.42 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/reusable-blocks/index.js 2.92 kB 0 B
build/rich-text/index.js 13.4 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 2.84 kB 0 B
build/viewport/index.js 1.86 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

gziolo
gziolo reviewed Dec 7, 2020
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some tweaking necessary to the lock file as explained in the comment.

Let's add CHANGELOG entries for @wordpress/babel-plugin-default and @wordpress/scripts to let people know (there should be very similar entries already to copy and edit).

package-lock.json Outdated Show resolved Hide resolved
@jsnajdr jsnajdr force-pushed the upgrade/babel-7.12 branch from 4927761 to 59f9f7e Compare December 8, 2020 08:15
@jsnajdr jsnajdr force-pushed the upgrade/babel-7.12 branch from 59f9f7e to 42ff4e5 Compare December 8, 2020 08:22
@jsnajdr
Copy link
Member Author

jsnajdr commented Dec 8, 2020

The linting CI tasks reports some pre-existing errors:

[1] /home/runner/work/gutenberg/gutenberg/packages/editor/src/components/post-saved-state/index.js
[1]   79:26  error  ["_links"] is better written in dot notation  dot-notation
[1] 
[1] /home/runner/work/gutenberg/gutenberg/packages/editor/src/components/post-trash/check.js
[1]   21:31  error  ["rest_base"] is better written in dot notation  dot-notation

I'm confused about this: the master branch checks are green, and I'm not aware of any changes introduced in this PR that would make the linter report new errors.

@jsnajdr
Copy link
Member Author

jsnajdr commented Dec 8, 2020

BTW I also had to upgrade browserslist from 4.14.0 to 4.15.0 to avoid Babel packages duplicating it. @babel/preset-env depends on core-js-compat that depends on browserslist@^4.15.0.

@gziolo
Copy link
Member

gziolo commented Dec 8, 2020

Those two linting errors are surprising but we can fix or disable them to move forward 🤷‍♂️

gziolo
gziolo approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very close to merge. Actually we only need to make CI happy and you can ship 🚢

packages/babel-preset-default/CHANGELOG.md Outdated Show resolved Hide resolved
@jsnajdr
Copy link
Member Author

jsnajdr commented Dec 8, 2020

Those two linting errors are surprising but we can fix or disable them to move forward

I'm working on this. A little trouble is that postType?.[ 'rest_base' ] complains about dot-notation, but postType?.rest_base triggers the camelcase (identifier not in camel case) rule for a change 🤷‍♂️

@jsnajdr
Copy link
Member Author

jsnajdr commented Dec 8, 2020

Those two linting errors are surprising but we can fix or disable them to move forward

Fixed in the latest commit.

Both violations are in places that use optional chaining. That makes me think that it has something to do with upgraded @babel/parser and how ESLint interacts with it through the babel-eslint module.

@gziolo
Copy link
Member

gziolo commented Dec 8, 2020

Everything is green 🎉

@jsnajdr jsnajdr merged commit 18349c4 into master Dec 8, 2020
@jsnajdr jsnajdr deleted the upgrade/babel-7.12 branch December 8, 2020 13:09
@github-actions github-actions bot added this to the Gutenberg 9.6 milestone Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@sgomes sgomes Awaiting requested review from sgomes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@adamziel adamziel Awaiting requested review from adamziel

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@atimmer atimmer Awaiting requested review from atimmer

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@dmsnell dmsnell Awaiting requested review from dmsnell

@draganescu draganescu Awaiting requested review from draganescu

@ellatrix ellatrix Awaiting requested review from ellatrix

@guarani guarani Awaiting requested review from guarani

@kevin940726 kevin940726 Awaiting requested review from kevin940726

@mmtr mmtr Awaiting requested review from mmtr

@nerrad nerrad Awaiting requested review from nerrad

@noisysocks noisysocks Awaiting requested review from noisysocks

@oandregal oandregal Awaiting requested review from oandregal

@ntwb ntwb Awaiting requested review from ntwb

@swissspidy swissspidy Awaiting requested review from swissspidy

@talldan talldan Awaiting requested review from talldan

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

Assignees

@jsnajdr jsnajdr

Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
Gutenberg 9.6
Development

Successfully merging this pull request may close these issues.
2 participants
@jsnajdr @gziolo