CI: Run date test timezone and locale variations using bash script #27600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
youknowriad
reviewed
Dec 9, 2020
.github/workflows/unit-test.yml
Outdated
|
|
||
| run: | | ||
| npm run test-unit -- --ci --maxWorkers=2 --cacheDirectory="$HOME/.jest-cache" \ | ||
| --testPathPattern="packages/date/" | ||
| npm run test-unit:date -- --ci --maxWorkers=2 --cacheDirectory="$HOME/.jest-cache" |
There was a problem hiding this comment.
Can we just run this as part of the js unit tests job instead of having a separate job?
There was a problem hiding this comment.
Potentially we could split the two lines into two "run" steps to have separate logs in the UI
There was a problem hiding this comment.
Done, much better! Thanks!
david-szabo97
added
[Package] Date
david-szabo97
changed the title
david-szabo97
requested review from
ajitbohra,
karmatosed,
mapk,
nerrad and
ntwb
as code owners
youknowriad
approved these changes
Dec 9, 2020
desrosj
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
This is much better than the original PR, in my opinion. In working on the GitHub Actions workflows across the rest of the organization, workflow runs and concurrent jobs are not truly unlimited, so we do want to be careful how many we add.
I am not against adding an additional date specific job within the unit test workflow, but only if it's a singular job. I am not too familiar with the JS testing infrastructure for Gutenberg, but it seems that would be difficult to accomplish in the current state due to the timezones and locales being passed through environment variables.
david-szabo97
force-pushed
the
try/run-date-function-variations-in-bash
branch
from
32dd8e4 to
9a00a1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related discussion: #27552 (comment)
To reduce jobs and CI entries, run date tests in different timezones and locales with a bash script.
How has this been tested?
npm run test-unit:dateScreenshots
A failing date test will report the timezone and locale it failed with:
See line 7371
Types of changes
non-breaking change
Checklist: