Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Add escaping functions to code examples #27603

Merged
merged 1 commit into from
Dec 10, 2020
Merged

[Documentation] Add escaping functions to code examples #27603

merged 1 commit into from
Dec 10, 2020

Conversation

zzap
Copy link
Member

@zzap zzap commented Dec 9, 2020 •
edited
Loading

As we aim to give good code examples that follow WordPress Coding Standards and best practices throughout the documentation, I added escaping versions of all internationalisation functions.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 9, 2020
@zzap zzap changed the title Add escaping functions to code examples [Documentation] Add escaping functions to code examples Dec 9, 2020
@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Dec 9, 2020
mkaz
mkaz approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the update. I can see how if someone copies the examples and then adds something that should be escaped it could cause problems.

@mkaz mkaz merged commit 4b07255 into WordPress:master Dec 10, 2020
@github-actions github-actions bot added this to the Gutenberg 9.6 milestone Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz mkaz approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 9.6
Development

Successfully merging this pull request may close these issues.
3 participants
@zzap @mkaz @skorasaurus