Refactor focus on mount #27698
Closed
Refactor focus on mount #27698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
cameronvoell,
chrisvanpatten,
guarani and
talldan
as code owners
|
Size Change: -5 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/refactor-focus-mount
branch
from
957a25d to
fb1ca6a
Compare
ellatrix
force-pushed
the
try/refactor-focus-mount
branch
from
fb1ca6a to
b976bb4
Compare
|
Closing in favour of #27699. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we have a setting on
Popoverand similar components to focus the first element on mount. For this, some DOM querying is required and a timeout because the child nodes are not immediately available.This is all unnecessary if the component that needs to be focussed takes care of that itself. In the whole codebase, it's only needed for the URL input in various popovers for different components.
I've change
focusOnMountonPopoverto accept a boolean value.How has this been tested?
Screenshots
Types of changes
Checklist: