Popover: use a11y hooks instead of HoCs #27707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -15 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
haha, duplicate of #27675 |
|
@youknowriad Oh, I didn't see. I'm happy you're trying this too. I don't think it can be done without wrapping the merged ref callback in |
|
Closing in favour of #27675 |
|
yes, what do yo think of the idea here #27710 still against it? |
|
Let's try and see if it works :) All that matters here is Popover using the hooks |
ellatrix
force-pushed
the
try/popover-a11y-hooks
branch
from
8d7f2df to
ec34edf
Compare
ellatrix
commented
Dec 14, 2020
| focusOnMount ? focusReturnRef : null, | ||
| focusOnMountRef, | ||
| ]; | ||
| const mergedRefs = useCallback( mergeRefs( allRefs ), allRefs ); |
There was a problem hiding this comment.
useCallback is necessary here, I'm getting e2e test failures otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the constrained tabbing and focus return HoCs with the new hooks.
How has this been tested?
Screenshots
Types of changes
Checklist: