Release script: Set draft status, and only remove after uploading asset #27713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
youknowriad
reviewed
Dec 14, 2020
| @@ -448,6 +456,19 @@ async function runGithubReleaseStep( | |||
| log( '>> The plugin ZIP has been successfully uploaded.' ); | |||
| } ); | |||
|
|
|||
| // Remove draft status from the Github release | |||
| await runStep( 'Publishing the Github release', abortMessage, async () => { | |||
There was a problem hiding this comment.
Is the new step necessary? I mean not just put this logic inside the previous step. (it's all related)
There was a problem hiding this comment.
I was considering that, but since release (now draft) creation and asset upload are separate, it seemed like removing the draft status should also be separate, since it's semantically not part of the asset upload step. (I don't feel strongly about this.)
youknowriad
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the release script, rather than creating a GH release, and then attaching the plugin zip release asset, this PR creates a release draft first, attaches the plugin zip, and only then removes the draft state.
This is a prerequisite for GH action-based automation such as #27591.
Spun off from #27591 to allow for more isolated review and testing.
How has this been tested?
gutenbergrepo (if you haven't already), and make sure it's up-to-date.bin/plugin/config.js(e.g. mine isockham). This is important, as you don't want to accidentally create a release in the official repo!./bin/plugin/cli.js stableand follow through the steps.Here's an example: https://github.com/ockham/gutenberg/releases/tag/v9.5.2
Types of changes
Release tooling.