Verse Block: Update CSS for frontend and editor #27734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
Moving these styles over make sense to me — this way things will be identical by default. I don't expect many themes would be overriding these rules differently. Conceptually, cc @jasmussen for a gut-check too. |
|
I dig it, even if we need to make a note in the theme updates. Before we change to pre-wrap, was there any context in the archives for why it was nowrap before? Here's a verse from Alice in Wonderland, that probably shouldn't wrap under any circumstance: |
|
It was added in #1809. No history on the |
|
I tried that Alice in Wonderland passage in a few themes, both before and after this PR, and it looks as expected in all cases. 😄 That being the case, I think this is fine to merge. At the very least, it helps clean up the style rules. 👍 |
kjellr
approved these changes
Dec 15, 2020
scruffian
force-pushed
the
fix/verse-block-css
branch
2 times, most recently
from
ae72ebf to
d8c1541
Compare
|
This appears to have caused and issue: Automattic/wp-calypso#48772 I'm very surprised at
This is on the frontend of a site where the verse block is expected to be rendered as follows:
(achieved by disabling the |
|
|
|
It seems pre wrap is added in the editor to RichText components as inline styles which means it shows properly on the editor but not in the frontend. |
This was referenced Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This consolidates the CSS for the frontend and the editor, so that the block looks the same in the editor and the front end. I think ultimately we'll be able to remove the editor.scss file altogether by moving font-size and padding to Global Styles.
How has this been tested?
In TT1 Blocks
Screenshots
Frontend
Editor
Types of changes
Bug fix
Checklist: