Verse Block: Add support for custom colors #27736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Block] Verse
scruffian
requested review from
ajitbohra,
chrisvanpatten,
mkaz and
talldan
as code owners
|
Size Change: -115 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
|
Hey Kerry @gwwar can you do a review of Ben's PR to add color to the Verse block? |
|
@scruffian do you mind rebasing so I can manually test? Code here looks good so far 👍 |
kjellr
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
I rebased this PR, and it's working nicely for me:
The /verse/editor.scss file only contained the single color rule which was removed by this PR, so I've gone ahead and deleted the file entirely. This could probably use one more set of 👀 before merge just to be sure that makes sense.
gwwar
reviewed
Apr 12, 2021
| @@ -1,3 +0,0 @@ | |||
| pre.wp-block-verse { | |||
| color: $gray-900; | |||
There was a problem hiding this comment.
This is probably okay to remove. It didn't look like we were applying this to the published view. Not sure why we needed this one.
|
Thanks, everyone! |
|
Thanks for taking care of this - I've been AFK! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for custom colors to the Verse bloc.
How has this been tested?
In TT1 Blocks
Screenshots
Types of changes
New feature
Checklist: