Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make links in gallery captions white #27743

Closed

Conversation

jffng
Copy link
Contributor

@jffng jffng commented Dec 15, 2020

This PR makes a small change to links inside image captions in the gallery block.

Since the caption text is white atop the default black gradient, I think the links also be white. Otherwise, they are unreadable when the default link color is a dark color.

Using TT1:

Before After
Screen Shot 2020-12-15 at 1 32 50 PM Screen Shot 2020-12-15 at 1 30 55 PM

@kjellr
Copy link
Contributor

kjellr commented Dec 16, 2020

Just FYI, there's a large Gallery refactor happening in #25940. Not sure if this is necessary or not alongside that work.

@jasmussen
Copy link
Contributor

Kjell makes a good point. There's an open caption question with that ongoing refactor — how will they display? I would hope that they look mostly identical to what exists, that should be the goal, and in that vein, this seems an okay change to land and for the reasons outlined. But definitely something to keep an eye on.

@jffng
Copy link
Contributor Author

jffng commented Dec 18, 2020

Ah thanks for that context. It appears that this change would create to conflict when that PR lands because of some scss refactoring and the addition of a "deprecated" sass file: https://github.com/WordPress/gutenberg/blob/0550bccc96d2115945da2d39212218a60fcd1baa/packages/block-library/src/gallery/deprecated.scss

I'll wait until that PR lands as it's quite active and revisit this change then... Thanks for the eyes!

@paaljoachim paaljoachim mentioned this pull request Feb 21, 2021
26 tasks
Base automatically changed from master to trunk March 1, 2021 15:45
@jffng
Copy link
Contributor Author

jffng commented Jul 13, 2021

Closing as this is well out of date at this point and the gallery refactor looks close to landing.

@jffng jffng closed this Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants