Change the way RTL styles get enqueued #28274
Merged
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
6 tasks
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
swissspidy
approved these changes
Jan 18, 2021
|
We should add the same change in logic for I guess there it would require some prior validation if the RTL version of the file exists. |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Jan 19, 2021
…etadata Related Gutenberg issue: WordPress/gutenberg#28274 With this change it is going to be possible to use the same pattern that wp_style_add_data uses for RTL handling. If the block style file with "-rtl.css" is included in addition to the regular style referenced in "block.json" file then it is going to be automatically registered. Props swisspidy, aristath. See #52301. git-svn-id: https://develop.svn.wordpress.org/trunk@49982 602fd350-edb4-49c9-b593-d223f7449a82
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Jan 19, 2021
…etadata Related Gutenberg issue: WordPress/gutenberg#28274 With this change it is going to be possible to use the same pattern that wp_style_add_data uses for RTL handling. If the block style file with "-rtl.css" is included in addition to the regular style referenced in "block.json" file then it is going to be automatically registered. Props swisspidy, aristath. See #52301. git-svn-id: https://develop.svn.wordpress.org/trunk@49982 602fd350-edb4-49c9-b593-d223f7449a82
|
I added very similar handling for In the future, we will be able to register all styles through |
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jan 19, 2021
…etadata Related Gutenberg issue: WordPress/gutenberg#28274 With this change it is going to be possible to use the same pattern that wp_style_add_data uses for RTL handling. If the block style file with "-rtl.css" is included in addition to the regular style referenced in "block.json" file then it is going to be automatically registered. Props swisspidy, aristath. See #52301. Built from https://develop.svn.wordpress.org/trunk@49982 git-svn-id: http://core.svn.wordpress.org/trunk@49683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Jan 19, 2021
…etadata Related Gutenberg issue: WordPress/gutenberg#28274 With this change it is going to be possible to use the same pattern that wp_style_add_data uses for RTL handling. If the block style file with "-rtl.css" is included in addition to the regular style referenced in "block.json" file then it is going to be automatically registered. Props swisspidy, aristath. See #52301. Built from https://develop.svn.wordpress.org/trunk@49982 git-svn-id: https://core.svn.wordpress.org/trunk@49683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way RTL styles get loaded. Instead of having conditionals in PHP to determine if we need to load the RTL styles or not, it now uses
wp_style_add_dataas proposed in #25220 (review)How has this been tested?
Tested using the RTL Tester plugin.
Checklist:
I've included developer documentation if appropriate.I've updated all React Native files affected by any refactorings/renamings in this PR.