E2E Tests: Try running in Firefox (in addition to Chrome) #28498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
the
[Type] Automated Testing
|
Size Change: +80 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Aah, we're using |
Yes, we don't want everyone to download 150-ish MB hoping they run e2e tests locally for every PR 😅 |
7 tasks
|
I think this would be easier after the Playwright migration is finished. See #38851. |
|
This is now possible after #44631 in Playwright. Should we close this now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First stab at running e2e tests in Firefox, when run in CI.
Sometimes we see errors that only manifest in Firefox, such as the issue that was fixed by #28212. In order to catch those earlier, it makes sense to add Firefox coverage to our automated tests.
Inspired by Automattic/jetpack#17893 (which I haven't gotten to work yet 😬)
How has this been tested?
See if the e2e tests GH Actions pass 🤞
To run locally (with tests visible):