Framework: Update Jest and partially React with MIT licensed version #2866
Conversation
gziolo
force-pushed
the
update/jest-deps
branch
from
7a73fe1 to
0ee6a01
Compare
gziolo
added
[Type] Automated Testing
gziolo
changed the title
| "eslint-plugin-jsx-a11y": "4.0.0", | ||
| "eslint-plugin-react": "6.10.3", | ||
| "expose-loader": "0.7.3", | ||
| "extract-text-webpack-plugin": "3.0.0", | ||
| "gettext-parser": "1.3.0", | ||
| "jest": "20.0.4", | ||
| "jest-junit-reporter": "1.1.0", |
There was a problem hiding this comment.
In my testing, it was being required as an enzyme peer dependency
There was a problem hiding this comment.
That's strange, I think I added it because we have that in Calypso to integrate with CircleCI.
There was a problem hiding this comment.
Yes, it was me with 1406fe8.
There was a problem hiding this comment.
Yes, but when upgrading to enzyme3, I dropped it and I had to add it again because it was a peer dependency. Maybe not with the current version of enzyme though
| @@ -51,6 +51,7 @@ | |||
| "autoprefixer": "6.7.7", | |||
| "babel-core": "6.26.0", | |||
| "babel-eslint": "7.2.3", | |||
| "babel-jest": "21.2.0", | |||
There was a problem hiding this comment.
Eslint complains now that it should be added explicitly.
Codecov Report
@@ Coverage Diff @@
## master #2866 +/- ##
==========================================
+ Coverage 33.9% 34.97% +1.07%
==========================================
Files 191 191
Lines 5699 5801 +102
Branches 999 1034 +35
==========================================
+ Hits 1932 2029 +97
- Misses 3187 3189 +2
- Partials 580 583 +3
Continue to review full report at Codecov.
|
Checklist:
This tries to land part of the #2813 as we are still having trouble integrating the latest Enzyme version with our tests. We want to start using the latest version of React on the frontend to catch the potential issues before we find a way to make all failing tests work with new React 16 Enzyme adapter.