Query pagination: remove div #28831
Merged
Query pagination: remove div #28831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -358 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Thanks for working on this Ella!
Code wise looks good and test failures are not related - unfortunately they are intermittent from Navigation issues.
Allow any formatting as long as it is not interactive, since the parent element is a link. Honestly I'm not sure if we should allow formatting here at all since this is a strange place for it. Formatting is supposed to be semantic.
I trust you better with this decision, due to all your experience with RichText. If you think it's better to remove all formatting, let's do it. My initial approach for allowing bold and italic only was subjective.
aristath
approved these changes
Feb 8, 2021
|
Ok, maybe it's better to leave formatting out of the formatting. I don't see much value here. We can always add formatting, but it's hard to remove later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #28125.
How has this been tested?
Screenshots
Types of changes
Checklist: