List all dependencies when checking licenses in NPM 7 #28909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NPM 7 by default only prints the first level of dependencies but we need all of them for this script.
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
fluiddot
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
gziolo
approved these changes
Feb 10, 2021
|
This file: Something like this should be enough: ## Unreleased
+
+ ### Enhancements
+
+ - Make `check-licenses` command compatible with npm v7 ([#28909](https://github.com/WordPress/gutenberg/pull/28909)).
## 13.0.0 (2021-01-21) |
|
Thanks @gziolo for the reminder! I've just updated the |
|
I added another commit, it needs a section to recognize this change as a minor version bump 😄 |
Oops sorry, I forgot to add the the section, thanks for the fix 😊 ! |
|
Thank you for the actual fix 😄 |
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NPM 7 by default only prints the first level of dependencies but we need all of them for the
check-licensesscript.Extracted from "Changes in npm v7":
How has this been tested?
npm i -g npm@latestnpm run check-licenses(this command should show some warnings)Screenshots
N/A
Types of changes
Bug fix
Checklist: