-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: output block position for screen readers. Update: refactor the way the screen reader information on block button is delivered. #29060
Closed
alexstine
wants to merge
46
commits into
WordPress:trunk
from
alexstine:new/output-block-position-sr
Closed
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
bf6325c
i
4d711e4
Try to import getBlockCount.
112ba24
Try to import getBlockCount.
06e53a6
Use existing selector.
d8fb0e2
Pass in rootClientId to getBlockCount.
bf04b90
Pass our new total arg in to the accessible label function.
b467a77
Attempt to fix tests.
7e119f9
Use description text to output instead of aria-label.
bb8ac20
A fix to button component to use proper ID passed in to span.
93e5256
Define custom unique description ID constructed with clientId of block.
0f4dc5a
Try to output accessible Block label after block title output.
bd2f11c
Render span instead of div.
8f8e0c0
Get rid of duplicate title. Add spacing instead of : .
22979b8
Auto format.
41259f4
Merge branch 'master' of https://github.com/wordpress/gutenberg into …
3da7129
Test case.
6f86d03
Modify the accessible description function with parent title.
219e94e
Change text.
4bae102
Formatting fixes and additional comments.
5b65ebc
No verify.
4b312f9
Try to sync package-lock.json with master.
3ef07e1
Refresh.
f5a163e
Revert package-lock.json to upstream master.
15d5381
Use createInterpolateElement for title output.
1e4bf55
Fix title block tests.
040516e
Fix title bugs. Output parentTitle in SR block description via sprint…
35e3e53
Merge branch 'master' of https://github.com/wordpress/gutenberg into …
857265d
Remove mods to button component.
2fdf221
Pass rootClientId from selector callback.
780f2c6
Merge branch 'master' of https://github.com/wordpress/gutenberg
b6108ef
Remove unused sprintf.
accb462
Merge branch 'master' of https://github.com/wordpress/gutenberg
f040379
Merge branch 'master' of https://github.com/wordpress/gutenberg into …
ba88fb9
Fix invalid sprintf arg.
ac76c53
Merge branch 'master' of https://github.com/wordpress/gutenberg into …
94387c7
Fix parentTitle output for blocks with label.
7fcb514
Give total variable a better descriptive name blocksTotal.
025c4ad
Merge branch 'master' of https://github.com/wordpress/gutenberg into …
96b20fb
Merge branch 'master' of https://github.com/wordpress/gutenberg
4f59b3f
Refresh.
0de9d39
Fix conflict.
a0c8034
Merge branch 'trunk' of https://github.com/wordpress/gutenberg into n…
32f297c
Correct error that popped up during merge from trunk.
8b4d2ce
Revert changes to title.
0a37674
Merge branch 'trunk' of https://github.com/wordpress/gutenberg into n…
2e925b0
Add title back to description.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little surprised there aren't unit tests for this function. Probably my fault as I think I initially wrote it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, just realise there are unit tests. So these will need to be updated, with new test cases added for the additional branches of code. Happy to help with that, either directly or by providing guidance, let me know.
There are docs for testing, but not sure how good they are.