api-fetch: Add incremental type checking #29685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
npm Packages
|
Size Change: -1 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Mar 10, 2021
| url?: string; | ||
| /** | ||
| * @default true | ||
| */ |
There was a problem hiding this comment.
Are we sure to be covering all the available options here? As per its docs, we claim to support all fetch() arguments. At first glance, I see we're missing method and body, but there are more for sure.
There was a problem hiding this comment.
Yes, as I said in the PR description:
We'll want to continue expanding the definition of ApiFetchRequestProps as we include new middlewares into the type checking
There are several other properties we're missing, the easiest way to cover them all is to add them as we use them (ultimately covering the whole gamut of them when we type the default fetch handler).
tyxla
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
This looks like a great start towards typing api-fetch 👍 Thanks @sarayourfriend!
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds incremental type checking to
api-fetch. We'll want to continue expanding the definition ofApiFetchRequestPropsas we include new middlewares into the type checking. This PR starts with just the basicnoncemiddleware.Part of #18838
How has this been tested?
Type checks pass. No runtime changes.
Types of changes
Non-breaking changes.
Checklist: