wp-env.json: Bump tt1-blocks dependency to v0.4.5 #30045
Conversation
ockham
added
the
[Type] Automated Testing
ockham
requested review from
mattwiebe,
vindl,
creativecoder,
Copons,
david-szabo97,
jeyip,
carolinan,
Addison-Stavlo and
a team
|
Size Change: 0 B Total Size: 1.46 MB ℹ️ View Unchanged
|
|
Note there's at least 1 change that needs to be made to e2e tests with v0.4.4 of tt1-blocks: |
|
I just noticed that while the version of TT1 Blocks was indeed bumped to 0.4.4, no git tag was added (as e2e tests revealed: So it looks like we'll have to take care of that first 😬 |
|
Sorry about that! I've published a new release for TT1 Blocks. |
Thanks a lot @kjellr! |
ockham
force-pushed
the
update/wp-env-tt1-blocks-0-4-4
branch
from
185574e to
e7eef51
Compare
Thanks @creativecoder! Fixed in e7eef51. |
|
e2e tests are currently failing at the following line: It seems like the |
ockham
requested review from
adamsilverstein,
adamziel,
ajlende,
atimmer,
cameronvoell,
chrisvanpatten,
dmsnell and
draganescu
as code owners
I don't think so, just testing it out they are outputting the expected string values when the tests run ('header','uncategorized',etc.) and not |
Doesn't seem like: gutenberg/.github/workflows/unit-test.yml Lines 95 to 101 in 2557a44 Plus I can repro locally. I checked the locally generated TT1 Blocks seems to set template areas fine: https://github.com/WordPress/theme-experiments/blob/tt1-blocks%400.4.5/tt1-blocks/experimental-theme.json
Yeah, definitely something we should figure out 🤔 Any chance there's actually something wrong with |
|
Using this to track down the issue: |
|
I believe I've tracked it down to this line returning |
|
Tracked it down further: gutenberg/lib/class-wp-theme-json-resolver.php Lines 513 to 538 in 2557a44 But when this function is called, So I guess it's another instance of the "calling a theme related function before WP has switched to that theme" 😬 cc/ @nosolosw |
To be precise, I think that that happens when |
Filed an issue: #30478 |
ockham
force-pushed
the
update/wp-env-tt1-blocks-0-4-4
branch
from
4601f72 to
5eb999b
Compare
ockham
added
the
[Status] Blocked
|
👋 Not sure if relevant, but I see this notice message when loading a request: (leaving a comment on the issue about theme.json support #30478, not sure I can repro the failure) |
Great digging, thanks for figuring out the cause of that! I think what you are proposing on that issue makes sense. |
|
The issue should now be fixed by #30830. Going to rebase 🤞 |
ockham
force-pushed
the
update/wp-env-tt1-blocks-0-4-4
branch
from
5eb999b to
d201cf8
Compare
|
Pushed one more commit to fix one remaining unit test. Should be ready for another look now 🙂 |
ockham
removed
the
[Status] Blocked
Description
As of #28741, we've been pinning the version of the Twenty Twenty One Blocks theme (
tt1-blocks) used by Gutenberg to a fixed version, in order to prevent breakage of e2e tests by changes to that theme, as previously seen with #28638.The version we pinned
tt1-blocksto was0.4.3. A new version --0.4.40.4.5-- has now been tagged, so let's try to update Gutenberg to use that.How has this been tested?
Verify that tests (unit and e2e) are passing (see cI). Some additional smoke testing (especially of the Site Editor) is also recommended.