Fix encoded characters in navigation link text

[donnapep]

Description

Fixes #30111. Renders title.raw instead of title.rendered.

How has this been tested?

1. Add the navigation block.
2. Add a new menu item.
3. Select adding a new Link and begin typing the title of a page that doesn't exist. When you do so, include &.
4. Select the option to create a page draft.
5. See that the menu item shows the ampersand.
6. Select adding a new Post Link and begin typing the title of a page that doesn't exist. When you do so, include &.
7. Select the option to create a post draft.

Screenshots

Types of changes

Bug fix

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[gwwar]

Whoops, looks like this one got lost in the PR list. The code change here looks correct. @donnapep do you mind rebasing with trunk (or let us know if you'd like us to take over). I can help review this one

[annezazu]

Seems like this one should likely be taken over :)

[getdave]

Thank you for raising this and apologies that it flew under my radar.

I've tested and I think it might be more complex than I'd hoped. Especially as it no longer appears to work.

Screen.Capture.on.2022-05-13.at.20-41-44.mov

I think this is all happened because we're escaping the title/label prematurely (i.e. before the point at which it is rendered).

The escaping of the label within the updateNavigationLinkBlockAttributes method which causes the post.title.rendered to be converted into an &. This still happens with .raw as shown in the video above.

Normal Post links are rendered into a <RichText> so the escaped HTML renders correctly. However, draft pages (those created inline within the Link UI) are rendered into a <span> which means that the escaped HTML shows up in it's raw form.

I will raise a PR which properly applies the escaping at the point of output which will allow us to be more selective in our application of escaping.

[getdave]

This was fixed here #41063