Fix content loss for group block #30460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
|
Tagging #30461 as a (possibly) more complete issue description. Happy to test once this is ready! |
youknowriad
force-pushed
the
fix/group-layout-regex
branch
from
f405050 to
69bfcee
Compare
|
Ok this looks to be working for me. @jeremyfelt mind testing a bit? thanks |
youknowriad
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Things are looking good for me. My original content is back in order and I've attempted to break things by nesting even more groups. All of the groups appear to have their inner container inserted when output and none are missing. I am not a regex expert, so I'll leave that review to others. :) Thanks for the quick fix, @youknowriad! |
|
All the merit goes to @ockham on this one |
|
Thanks for testing, folks! It might be a bit safer to add back the The I'll add back the |
|
@ockham The latest change is working for me in production (where I've sadly let PHP 7.0 be 🤦🏻). I've switched my local environment back to PHP 7.4, so I can't test more thoroughly right now, but things generally look good! |
ockham
approved these changes
Apr 1, 2021
|
e2e Test Admin - 4 is failing because of an unrelated I'll go ahead and merge. |
ockham
added a commit
that referenced
this pull request
Apr 1, 2021
Co-authored-by: Bernie Reiter <[email protected]>
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30461
In #30443 (comment) it was reported that in Gutenberg 10.3, potential content loss can happen in some situations when using the group block with a lot of nesting.
This PR is an attempt to solve that